Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pcre with pcre2 #6883

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Replace pcre with pcre2 #6883

merged 2 commits into from
Mar 12, 2022

Conversation

ndren
Copy link
Contributor

@ndren ndren commented Mar 10, 2022

Thank you @psychon for fixing the patch I've sent over email. This should fix #6838.

@ndren
Copy link
Contributor Author

ndren commented Mar 10, 2022

I'm not too sure how to fix the build since pcre was not listed in any of the .yml build files. Any suggestions?

@emersion
Copy link
Member

I guess the dependency wasn't explicit because base system packages depend on pcre v1, so we got it "by chance". We need to make the pcre v2 dep explicit in .builds/*.yml.

emersion
emersion reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks good to me!

@bl4ckb0ne
Copy link
Contributor

The package seems to have a different name on alpine. Maybe drop the suffix after the 2?

$ apk search libpcre2
libpcre2-32-10.39-r0
libpcre2-16-10.39-r0
pcre2-dev-10.39-r0
pcre2-10.39-r0

@ndren
Copy link
Contributor Author

ndren commented Mar 11, 2022

Thank you, now it's building.

emersion
emersion approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion merged commit f614f35 into swaywm:master Mar 12, 2022
@emersion emersion mentioned this pull request Mar 12, 2022
Closed
@Scrumplex Scrumplex mentioned this pull request Mar 13, 2022
Closed
@emersion emersion mentioned this pull request Nov 26, 2022
Closed
@Y7n05h Y7n05h mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace pcre with pcre2
3 participants
@ndren @emersion @bl4ckb0ne